[all-commits] [llvm/llvm-project] 642216: [demangler] Make OutputBuffer non-copyable

[Nathan Sidwell via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 64221645a824f0b70ae130001b37ac01095aa806
      https://github.com/llvm/llvm-project/commit/64221645a824f0b70ae130001b37ac01095aa806
  Author: Nathan Sidwell <nathan at acm.org>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M libcxxabi/src/demangle/Utility.h
    M llvm/include/llvm/Demangle/Utility.h

  Log Message:
  -----------
  [demangler] Make OutputBuffer non-copyable

In addressing the buffer ownership API, I discovered a rogue member
function that returned by value rather than by reference. It clearly
intended to return by reference, but because the copy ctor wasn't
deleted this wasn't caught.

It is not necessary to make this a move-only type, although that would
be an alternative.

Reviewed By: bruno

Differential Revision: https://reviews.llvm.org/D120901