[all-commits] [llvm/llvm-project] e3a9f6: [Bitcode] Fully support opaque pointer auto upgrade

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e3a9f68e2c1d5af6f3d1a275b1887e36171f94f3
      https://github.com/llvm/llvm-project/commit/e3a9f68e2c1d5af6f3d1a275b1887e36171f94f3
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M llvm/lib/Bitcode/Reader/BitcodeReader.cpp
    M llvm/test/Bitcode/case-ranges-3.3.ll
    M llvm/test/Bitcode/function-local-metadata.3.5.ll

  Log Message:
  -----------
  [Bitcode] Fully support opaque pointer auto upgrade

This completes the propagation of type IDs through bitcode reading,
and switches remaining uses of getPointerElementType() to use
contained type IDs.

The main new thing here is that sometimes we need to create a type
ID for a type that was not explicitly encoded in bitcode (or we
don't know its ID at the current point). For such types we create a
"virtual" type ID, which is cached based on the type and the
contained type IDs. Luckily, we generally only need zero or one
contained type IDs, and in the one case where we need two, we can
get away with not including it in the cache key.

With this change, we pass the entirety of llvm-test-suite at O3
with opaque pointers.

Differential Revision: https://reviews.llvm.org/D120471