[all-commits] [llvm/llvm-project] d7f922: [MLIR] [AMDGPU] Use correct flags when building Se...

Krzysztof Drewniak via All-commits all-commits at lists.llvm.org
Thu Mar 3 13:44:41 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d7f9220bb63405f2f874e29eaa3a98a45b2ac452
      https://github.com/llvm/llvm-project/commit/d7f9220bb63405f2f874e29eaa3a98a45b2ac452
  Author: Krzysztof Drewniak <Krzysztof.Drewniak at amd.com>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M mlir/lib/Dialect/GPU/CMakeLists.txt

  Log Message:
  -----------
  [MLIR] [AMDGPU] Use correct flags when building SerializeToHsaco

The SerializeToHsaco pass does not depend on ROCm being available on
the build system - it only requires ROCm to be present at runtime.
However, the CMake file that built it tested for
MLIR_ENABLE_ROCM_RUNNER , which implies that ROCm is currently
available and is used to control building ROCm integration tests.

Referencing MLIR_ENABLE_ROCM_RUNNER instead of
MLIR_ENABLE_ROCM_CONVERSIONS in the SerializeToHsaco build therefore
causes problems for clients who wish to build projects that depend on
this pass on a system without an AMD GPU present.

Reviewed By: whchung

Differential Revision: https://reviews.llvm.org/D120663




More information about the All-commits mailing list