[all-commits] [llvm/llvm-project] 554839: [mlir] support f80 and f128 in parseOptionalType

ftynse via All-commits all-commits at lists.llvm.org
Wed Mar 2 05:57:10 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 554839ecdf73104777f38830b5dbcfbf4a1804d4
      https://github.com/llvm/llvm-project/commit/554839ecdf73104777f38830b5dbcfbf4a1804d4
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2022-03-02 (Wed, 02 Mar 2022)

  Changed paths:
    M mlir/lib/Parser/TypeParser.cpp
    M mlir/test/IR/parser.mlir
    M mlir/test/lib/Dialect/Test/TestOps.td

  Log Message:
  -----------
  [mlir] support f80 and f128 in parseOptionalType

This seems to have been forgotten when the types were introduced.

Reviewed By: wsmoses

Differential Revision: https://reviews.llvm.org/D120737


  Commit: f64170aa1d2a416fbecf46a4b0adc3a7e0b0d71a
      https://github.com/llvm/llvm-project/commit/f64170aa1d2a416fbecf46a4b0adc3a7e0b0d71a
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2022-03-02 (Wed, 02 Mar 2022)

  Changed paths:
    M mlir/lib/Interfaces/DataLayoutInterfaces.cpp
    M mlir/test/Dialect/DLTI/invalid.mlir
    M mlir/test/Interfaces/DataLayoutInterfaces/query.mlir
    M mlir/test/Interfaces/DataLayoutInterfaces/types.mlir

  Log Message:
  -----------
  [mlir] Data layout for integer and float types

Add support for integer and float types into the data layout subsystem with
default logic similar to LLVM IR. Given the flexibility of the sybsystem, the
logic can be easily overwritten by operations if necessary. This provides the
connection necessary, e.g., for the GPU target where alignment requirements for
integers and floats differ from those provided by default (although still
compatible with the LLVM IR model). Previously, it was impossible to use
non-default alignment requirements for integer and float types, which could
lead to incorrect address and size calculations when targeting GPUs.

Depends On D120737

Reviewed By: wsmoses

Differential Revision: https://reviews.llvm.org/D120739


  Commit: ea998709ebbb2c0fa4e0e04cc917d0a4f9959d06
      https://github.com/llvm/llvm-project/commit/ea998709ebbb2c0fa4e0e04cc917d0a4f9959d06
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2022-03-02 (Wed, 02 Mar 2022)

  Changed paths:
    M mlir/include/mlir/Target/LLVMIR/Import.h
    M mlir/lib/Target/LLVMIR/CMakeLists.txt
    M mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp
    M mlir/lib/Target/LLVMIR/ConvertToLLVMIR.cpp
    M mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
    A mlir/test/Target/LLVMIR/data-layout.ll
    A mlir/test/Target/LLVMIR/data-layout.mlir
    M utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  Log Message:
  -----------
  [mlir] Add partial support for translating data layout

Add support for translating data layout specifications for integer and float
types between MLIR and LLVM IR. This is a first step towards removing the
string-based LLVM dialect data layout attribute on modules. The latter is still
available and will remain so until the first-class MLIR modeling can fully
replace it.

Depends On D120739

Reviewed By: wsmoses

Differential Revision: https://reviews.llvm.org/D120740


Compare: https://github.com/llvm/llvm-project/compare/ab2cbb8466f0...ea998709ebbb


More information about the All-commits mailing list