[all-commits] [llvm/llvm-project] eb4dcc: [libcxx] [test] Add a 'win32-' prefix to the 'brok...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Tue Mar 1 11:35:26 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: eb4dcc744d5ca7ce59751cab9a303db587341960
      https://github.com/llvm/llvm-project/commit/eb4dcc744d5ca7ce59751cab9a303db587341960
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-03-01 (Tue, 01 Mar 2022)

  Changed paths:
    M libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/tolower_1.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/tolower_many.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/toupper_1.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/toupper_many.pass.cpp
    M libcxx/test/std/re/re.traits/translate_nocase.pass.cpp
    M libcxx/utils/libcxx/test/features.py

  Log Message:
  -----------
  [libcxx] [test] Add a 'win32-' prefix to the 'broken-utf8-wchar-ctype' feature

This was suggested in the review of https://reviews.llvm.org/D120022.

Also indent the code for the compilation test one step compared
to the surrounding expression.

Differential Revision: https://reviews.llvm.org/D120469


  Commit: d2617a6b5250d79ea182d6e5b557704afbff6576
      https://github.com/llvm/llvm-project/commit/d2617a6b5250d79ea182d6e5b557704afbff6576
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-03-01 (Tue, 01 Mar 2022)

  Changed paths:
    A libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.hex.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp
    A libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.hex.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
    M libcxx/utils/libcxx/test/features.py

  Log Message:
  -----------
  [libcxx] [test] Fix the put_double, put_long_double tests for clang-cl

These tests are hit hard by a bug that is fixed in a newer version
of UCRT. Add a test for the specific bug, and XFAIL the tests if
that bug is present (as it is in CI).

Split out hex formatting of floats to separate test files, that
are excluded with `XFAIL: msvc`. (Based on reading the C standard for
printf formatting, it seems like this isn't necessarily a proper bug
in printf, but just a case of differing optional behaviour.)

Differential Revision: https://reviews.llvm.org/D120022


Compare: https://github.com/llvm/llvm-project/compare/261419273a0a...d2617a6b5250


More information about the All-commits mailing list