[all-commits] [llvm/llvm-project] 53dbed: [InstCombine] add test for copysign with FMF propa...

Sanjay Patel via All-commits all-commits at lists.llvm.org
Tue Mar 1 05:53:18 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 53dbedcd188a83cb945d95a8e7d536917a2e9934
      https://github.com/llvm/llvm-project/commit/53dbedcd188a83cb945d95a8e7d536917a2e9934
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-03-01 (Tue, 01 Mar 2022)

  Changed paths:
    M llvm/test/Transforms/InstCombine/select.ll

  Log Message:
  -----------
  [InstCombine] add test for copysign with FMF propagation; NFC

This is a miscompile as noted in #54077.


  Commit: 84812b9b072a513acfa76149c5a481d4eb8a511d
      https://github.com/llvm/llvm-project/commit/84812b9b072a513acfa76149c5a481d4eb8a511d
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-03-01 (Tue, 01 Mar 2022)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
    M llvm/test/Transforms/InstCombine/select.ll

  Log Message:
  -----------
  [InstCombine] drop FMF in select->copysign transform

It is not correct to propagate flags from the select
to the new instructions:
https://alive2.llvm.org/ce/z/tNATrd
https://alive2.llvm.org/ce/z/VwcVzn

Fixes #54077


Compare: https://github.com/llvm/llvm-project/compare/c2428a4fad34...84812b9b072a


More information about the All-commits mailing list