[all-commits] [llvm/llvm-project] 5c73db: [mlir] disallow side-effecting ops in llvm.mlir.gl...

ftynse via All-commits all-commits at lists.llvm.org
Tue Mar 1 05:16:24 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5c73db24df14501e1a76ef2e31111562a3a3287d
      https://github.com/llvm/llvm-project/commit/5c73db24df14501e1a76ef2e31111562a3a3287d
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2022-03-01 (Tue, 01 Mar 2022)

  Changed paths:
    M mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
    M mlir/test/Dialect/LLVMIR/invalid.mlir

  Log Message:
  -----------
  [mlir] disallow side-effecting ops in llvm.mlir.global

The llvm.mlir.global operation accepts a region as initializer. This region
corresponds to an LLVM IR constant expression and therefore should not accept
operations with side effects. Add a corresponding verifier.

Reviewed By: wsmoses, bondhugula

Differential Revision: https://reviews.llvm.org/D120632




More information about the All-commits mailing list