[all-commits] [llvm/llvm-project] cd1489: Clarify documentation of cpu_dispatch/cpu_specific

Erich Keane via All-commits all-commits at lists.llvm.org
Mon Feb 28 07:08:53 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cd1489bb58bb61276e73c91ff42dcf6a3febe650
      https://github.com/llvm/llvm-project/commit/cd1489bb58bb61276e73c91ff42dcf6a3febe650
  Author: Erich Keane <erich.keane at intel.com>
  Date:   2022-02-28 (Mon, 28 Feb 2022)

  Changed paths:
    M clang/include/clang/Basic/AttrDocs.td

  Log Message:
  -----------
  Clarify documentation of cpu_dispatch/cpu_specific

There has been some internal confusion lately as to how cpu_dispatch and
cpu_specific dispatch to processors, so this patch clarifies the
documentation to make it more clear that:

1- Unlike ICC, we do not consider the vendor string (that is, an AMD
processor might result in something other than generic)

2- there are some processors that aren't really distinguishable thanks
to the library limitation, so the variant being selected is unspecified.

In reality, I believe the 'stable_sort' makes it so the 1st one that
meets the requirements is the one that is selected (and that matches my
experimented result), but I don't want to limit our implementation.




More information about the All-commits mailing list