[all-commits] [llvm/llvm-project] 12c9c4: [lldb/host] Remove monitor_signals argument from p...

[Pavel Labath via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 12c9c4a8853740c41b183495f4d9931e7eee5268
      https://github.com/llvm/llvm-project/commit/12c9c4a8853740c41b183495f4d9931e7eee5268
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2022-02-24 (Thu, 24 Feb 2022)

  Changed paths:
    M lldb/include/lldb/Host/Host.h
    M lldb/include/lldb/Host/HostNativeProcessBase.h
    M lldb/include/lldb/Host/HostProcess.h
    M lldb/include/lldb/Host/ProcessLaunchInfo.h
    M lldb/include/lldb/Host/posix/HostProcessPosix.h
    M lldb/include/lldb/Host/windows/HostProcessWindows.h
    M lldb/source/Host/common/Host.cpp
    M lldb/source/Host/common/HostProcess.cpp
    M lldb/source/Host/common/MonitoringProcessLauncher.cpp
    M lldb/source/Host/common/ProcessLaunchInfo.cpp
    M lldb/source/Host/macosx/objcxx/Host.mm
    M lldb/source/Host/posix/HostProcessPosix.cpp
    M lldb/source/Host/windows/HostProcessWindows.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
    M lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.h
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
    M lldb/unittests/tools/lldb-server/tests/TestClient.cpp

  Log Message:
  -----------
  [lldb/host] Remove monitor_signals argument from process monitoring functions

All current callers set the argument to false. monitor_signals=true used
to be used in the Process plugins (which needed to know when the
debugged process gets a signal), but this implementation has several
serious issues, which means that individual process plugins now
orchestrate the monitoring of debugged processes themselves.

This allows us to simplify the implementation (no need to play with
process groups), and the interface (we only catch fatal events, so the
callback is always called just once).

Differential Revision: https://reviews.llvm.org/D120425