[all-commits] [llvm/llvm-project] ff3f3a: [AArch64][AsmParser] Arch directives should set im...

[sdesmalen-arm via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ff3f3a54e2d1b05c36943bf88ae0be7475d622ed
      https://github.com/llvm/llvm-project/commit/ff3f3a54e2d1b05c36943bf88ae0be7475d622ed
  Author: Sander de Smalen <sander.desmalen at arm.com>
  Date:   2022-02-24 (Thu, 24 Feb 2022)

  Changed paths:
    M llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
    M llvm/test/MC/AArch64/SVE/directive-arch.s
    M llvm/test/MC/AArch64/SVE/directive-arch_extension.s
    A llvm/test/MC/AArch64/SVE/directive-cpu-negative.s
    A llvm/test/MC/AArch64/SVE/directive-cpu.s

  Log Message:
  -----------
  [AArch64][AsmParser] Arch directives should set implied features.

When assembling for example an SVE instruction with the `.arch +sve2` directive,
+sve should be implied by setting +sve2, similar to what would happen if
one would pass the mattr=+sve2 flag on the command-line.

The AsmParser doesn't set the implied features, meaning that the SVE
instruction does not assemble. This patch fixes that.

Note that the same does not hold when disabling a feature. For example,
+nosve2 does not imply +nosve.

Reviewed By: c-rhodes

Differential Revision: https://reviews.llvm.org/D120259