[all-commits] [llvm/llvm-project] 8182db: [compiler-rt][builtins] Fix CMake builtin target flag
Tobias Hieta via All-commits
all-commits at lists.llvm.org
Wed Feb 23 01:23:29 PST 2022
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 8182dba0c2981690dda3cb8be6e4ec085bf9b2a1
https://github.com/llvm/llvm-project/commit/8182dba0c2981690dda3cb8be6e4ec085bf9b2a1
Author: Tobias Hieta <tobias at hieta.se>
Date: 2022-02-23 (Wed, 23 Feb 2022)
Changed paths:
M compiler-rt/cmake/Modules/BuiltinTests.cmake
Log Message:
-----------
[compiler-rt][builtins] Fix CMake builtin target flag
clang-cl doesn't support -target <target>, instead it only supports
--target=<target> so building a RUNTIME configuration for clang-cl
ended up in never building builtins. Which in turn lead to clang-cl
not being able to find the runtime libraries because we depend
on the compiler_rt.builtins.lib being in the runtime dir for the
Driver to add it as a candidate.
I don't think this should have any downsides since most the code
these days are using --target=<target> instead of the old syntax.
Reviewed By: mstorsjo
Differential Revision: https://reviews.llvm.org/D120308
More information about the All-commits
mailing list