[all-commits] [llvm/llvm-project] 1da213: [pdl] Remove `NoSideEffect` from all PDL ops

[Jeff Niu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1da213836b43e5c646a82a1e0e191aee7836e37e
      https://github.com/llvm/llvm-project/commit/1da213836b43e5c646a82a1e0e191aee7836e37e
  Author: Mogball <jeffniu22 at gmail.com>
  Date:   2022-02-22 (Tue, 22 Feb 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/PDL/IR/PDLOps.td

  Log Message:
  -----------
  [pdl] Remove `NoSideEffect` from all PDL ops

This trait results in PDL ops being erroneously CSE'd. These ops are side-effect free in the rewriter but not in the matcher (where unused values aren't allowed anyways). These ops should have a more nuanced side-effect modeling, this is fixing a bug introduced by a previous change.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D120222