[all-commits] [llvm/llvm-project] f5efe2: [mlir] Propagate NaNs in PolynomialApproximation

Tres via All-commits all-commits at lists.llvm.org
Fri Feb 18 00:25:54 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f5efe2807056d3fa525e51d35ea94c91e0945eb2
      https://github.com/llvm/llvm-project/commit/f5efe2807056d3fa525e51d35ea94c91e0945eb2
  Author: Tres Popp <tpopp at google.com>
  Date:   2022-02-18 (Fri, 18 Feb 2022)

  Changed paths:
    M mlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp
    M mlir/test/Dialect/Math/polynomial-approximation.mlir
    M mlir/test/mlir-cpu-runner/math-polynomial-approx.mlir

  Log Message:
  -----------
  [mlir] Propagate NaNs in PolynomialApproximation

Previously, NaNs would be dropped in favor of bounded values which was
strictly incorrect. Now the min/max operation propagate this
information. Not all uses of min/max need this, but the given change
will help protect future additions, and this prevents the need for an
additional cmpf and select operation to handle NaNs.

Differential Revision: https://reviews.llvm.org/D120020




More information about the All-commits mailing list