[all-commits] [llvm/llvm-project] 4dfa68: [NFC] Fix debug-info-hotpatch.cpp failure due to d...

Zahira Ammarguellat via All-commits all-commits at lists.llvm.org
Thu Feb 17 11:00:10 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4dfa68e483137cc13eb9027c0dd834ede19f2fd4
      https://github.com/llvm/llvm-project/commit/4dfa68e483137cc13eb9027c0dd834ede19f2fd4
  Author: Zahira Ammarguellat <zahira.ammarguellat at intel.com>
  Date:   2022-02-17 (Thu, 17 Feb 2022)

  Changed paths:
    M clang/test/CodeGenCXX/debug-info-hotpatch.cpp

  Log Message:
  -----------
  [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue.

In our downstream, we discovered that the that the .* wildcard
in debug-info-hotpatch.cpp (added https://reviews.llvm.org/D116511)
ended up matching the entire line on our Windows configurations, causing
the -function-padmin check to already be consumed. After digging into it
we weren't able to find any sort of reason why the platform would matter
here, however we suspect there must be some difference in the regex
matcher between systems.
This NFC patch replaces the regex with a more conservative regex that
prevents this from happening by replacing the . match with an 'everything
but double-quote match, [^"].

https://reviews.llvm.org/D120066




More information about the All-commits mailing list