[all-commits] [llvm/llvm-project] d20e01: Revert "[NFC][compiler-rt] Format file lib/builtin...

Eli Friedman via All-commits all-commits at lists.llvm.org
Thu Feb 17 02:20:32 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d20e01bb06fb81a7584c4ae7c7daf5aec2ed0a1a
      https://github.com/llvm/llvm-project/commit/d20e01bb06fb81a7584c4ae7c7daf5aec2ed0a1a
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2022-02-17 (Thu, 17 Feb 2022)

  Changed paths:
    M compiler-rt/lib/builtins/arm/sync-ops.h

  Log Message:
  -----------
  Revert "[NFC][compiler-rt] Format file lib/builtins/arm/sync-ops.h"

This reverts commit f165c23bf3598990aaf2174a6bc40be75199ee1a.

Part of revert sequence for 910a642c0a.


  Commit: 0389f2edf7c252e49323ae0ca6adfea9f2614f6d
      https://github.com/llvm/llvm-project/commit/0389f2edf7c252e49323ae0ca6adfea9f2614f6d
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2022-02-17 (Thu, 17 Feb 2022)

  Changed paths:
    M compiler-rt/cmake/Modules/CompilerRTUtils.cmake
    M compiler-rt/cmake/config-ix.cmake
    M compiler-rt/lib/builtins/CMakeLists.txt
    M compiler-rt/lib/builtins/arm/sync-ops.h

  Log Message:
  -----------
  Revert "[compiler-rt] Implement  ARM atomic operations for architectures without SMP support"

This reverts commit 910a642c0a5b66a8d2517026b890a1acdc447f19.

There are serious correctness issues with the current approach: __sync_*
routines which are not actually atomic should not be enabled by default.

I'll continue discussion on the review.


Compare: https://github.com/llvm/llvm-project/compare/f75da0c8e65c...0389f2edf7c2


More information about the All-commits mailing list