[all-commits] [llvm/llvm-project] 77c7ce: [libcxx] [test] Make the put_long_double test pass...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Thu Feb 17 00:55:08 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 77c7ce03845d31b1c92cc2a93d56f2efa485964f
      https://github.com/llvm/llvm-project/commit/77c7ce03845d31b1c92cc2a93d56f2efa485964f
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-02-17 (Thu, 17 Feb 2022)

  Changed paths:
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Make the put_long_double test pass on mingw, clarify quirks in put_double

Expect the same NAN formatting on Windows as on Glibc. (Both MSVC and
MinGW produce the same formatting there.)

The hex float formatting tests pass on MinGW, so opt in to those tests.

Document exactly what issues are remaining in Clang-cl/MSVC
configurations. (It's easily possible to make the tests pass there too,
but it requires a whole lot of small-scope ifndefs in the test file;
around 60 ifdefs in total for those both test files. Those could
be avoided if the CI environment could run with a newer version
of UCRT, but that's nontrivial to fix right away.)

Differential Revision: https://reviews.llvm.org/D119766


  Commit: f081cc50372f9415ef4fa2204a4b7f54153af455
      https://github.com/llvm/llvm-project/commit/f081cc50372f9415ef4fa2204a4b7f54153af455
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-02-17 (Thu, 17 Feb 2022)

  Changed paths:
    M libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_one_wide.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Fix the locale get_one_wide test for windows and glibc

Differential Revision: https://reviews.llvm.org/D119790


  Commit: 83c2aa467e22f85a0952fb1788771647829d9633
      https://github.com/llvm/llvm-project/commit/83c2aa467e22f85a0952fb1788771647829d9633
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-02-17 (Thu, 17 Feb 2022)

  Changed paths:
    M libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_date.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_date_wide.pass.cpp

  Log Message:
  -----------
  [libcxx] [test] Fix locale.time.get.byname get_date and get_date_wide on Windows

Also apply the same fix on glibc. This takes the test one step closer
to passing on glibc, but it still fails on the zh_CN test (which
requires a more involved fix in libc++ itself).

Differential Revision: https://reviews.llvm.org/D119791


Compare: https://github.com/llvm/llvm-project/compare/32d2473a5dba...83c2aa467e22


More information about the All-commits mailing list