[all-commits] [llvm/llvm-project] 5244ef: [libcxxabi] [test] Depend on unwind only if available

Michał Górny via All-commits all-commits at lists.llvm.org
Wed Feb 16 10:31:00 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5244ef0faf5595495c1adedfa16c346d35caebdf
      https://github.com/llvm/llvm-project/commit/5244ef0faf5595495c1adedfa16c346d35caebdf
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2022-02-16 (Wed, 16 Feb 2022)

  Changed paths:
    M libcxxabi/test/CMakeLists.txt

  Log Message:
  -----------
  [libcxxabi] [test] Depend on unwind only if available

When building libcxxabi via LLVM_ENABLE_RUNTIMES=libcxxabi the CMake
invocation fails because of missing "unwind" target.  However,
if the extraneous dependency is removed, the library builds just fine
against installed libunwind and tests work fine.  To fix this,
add the dependency only if the target actually exists.

Differential Revision: https://reviews.llvm.org/D119538


  Commit: 2c5c243bb5152de35c41f5880271451fce6165d0
      https://github.com/llvm/llvm-project/commit/2c5c243bb5152de35c41f5880271451fce6165d0
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2022-02-16 (Wed, 16 Feb 2022)

  Changed paths:
    M llvm/bindings/ocaml/README.txt
    M llvm/cmake/config-ix.cmake
    M llvm/test/Bindings/OCaml/lit.local.cfg
    M llvm/test/CMakeLists.txt
    M llvm/test/lit.site.cfg.py.in
    M llvm/utils/gn/secondary/llvm/test/BUILD.gn

  Log Message:
  -----------
  [llvm] [bindings/OCaml] Remove unused dep on ounit2

Remove the dependency on ounit2 and the relevant lit code.  It seems
that ounit2 is not used at all and all OCaml binding tests pass without
it installed.

Thanks for Shiwei Weng and Josh Berdine for bringing this to
my attention.

Differential Revision: https://reviews.llvm.org/D119884


Compare: https://github.com/llvm/llvm-project/compare/b5c9512df2a5...2c5c243bb515


More information about the All-commits mailing list