[all-commits] [llvm/llvm-project] 785337: [libc++] [test] Qualify `move` as `std::move` in a...

Quuxplusone via All-commits all-commits at lists.llvm.org
Wed Feb 16 08:04:06 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7853371146d1f40513d5dfe5bc6b3f958cda97af
      https://github.com/llvm/llvm-project/commit/7853371146d1f40513d5dfe5bc6b3f958cda97af
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2022-02-16 (Wed, 16 Feb 2022)

  Changed paths:
    M libcxx/test/std/input.output/file.streams/fstreams/filebuf.assign/move_assign.pass.cpp
    M libcxx/test/std/input.output/file.streams/fstreams/fstream.assign/move_assign.pass.cpp
    M libcxx/test/std/input.output/file.streams/fstreams/ifstream.assign/move_assign.pass.cpp
    M libcxx/test/std/input.output/file.streams/fstreams/ofstream.assign/move_assign.pass.cpp
    M libcxx/test/std/input.output/string.streams/stringbuf/stringbuf.assign/move.pass.cpp
    M libcxx/test/std/strings/basic.string/string.nonmembers/string_op+/char_string.pass.cpp
    M libcxx/test/std/strings/basic.string/string.nonmembers/string_op+/pointer_string.pass.cpp
    M libcxx/test/std/strings/basic.string/string.nonmembers/string_op+/string_char.pass.cpp
    M libcxx/test/std/strings/basic.string/string.nonmembers/string_op+/string_pointer.pass.cpp
    M libcxx/test/std/strings/basic.string/string.nonmembers/string_op+/string_string.pass.cpp

  Log Message:
  -----------
  [libc++] [test] Qualify `move` as `std::move` in a lot of tests. NFCI.

We shouldn't be calling `move` via ADL -- and neither should anybody
in the wild be calling it via ADL, so it's not like we need to test
this ADL ability of `move` in particular.

Reviewed as part of D119860.


  Commit: 5ffe11a9fccfffbabbea5bbcc1cfd4b21af6d631
      https://github.com/llvm/llvm-project/commit/5ffe11a9fccfffbabbea5bbcc1cfd4b21af6d631
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2022-02-16 (Wed, 16 Feb 2022)

  Changed paths:
    M libcxx/test/std/containers/associative/map/map.cons/assign_initializer_list.pass.cpp
    M libcxx/test/std/containers/associative/map/map.cons/copy.pass.cpp
    M libcxx/test/std/containers/associative/map/map.cons/copy_alloc.pass.cpp
    M libcxx/test/std/containers/associative/map/map.cons/copy_assign.pass.cpp
    M libcxx/test/std/containers/associative/map/map.cons/initializer_list.pass.cpp
    M libcxx/test/std/containers/associative/map/map.cons/initializer_list_compare.pass.cpp
    M libcxx/test/std/containers/associative/map/map.cons/initializer_list_compare_alloc.pass.cpp
    M libcxx/test/std/containers/associative/map/map.cons/iter_iter.pass.cpp
    M libcxx/test/std/containers/associative/map/map.cons/iter_iter_comp.pass.cpp
    M libcxx/test/std/containers/associative/map/map.cons/iter_iter_comp_alloc.pass.cpp
    M libcxx/test/std/containers/associative/map/map.cons/move.pass.cpp
    M libcxx/test/std/containers/associative/map/map.modifiers/emplace.pass.cpp
    M libcxx/test/std/containers/associative/map/map.modifiers/emplace_hint.pass.cpp
    M libcxx/test/std/containers/associative/map/map.modifiers/erase_iter.pass.cpp
    M libcxx/test/std/containers/associative/map/map.modifiers/erase_iter_iter.pass.cpp
    M libcxx/test/std/containers/associative/map/map.modifiers/erase_key.pass.cpp
    M libcxx/test/std/containers/associative/map/map.modifiers/insert_initializer_list.pass.cpp
    M libcxx/test/std/containers/associative/map/map.modifiers/insert_iter_iter.pass.cpp
    M libcxx/test/std/containers/associative/map/map.ops/equal_range.pass.cpp
    M libcxx/test/std/containers/associative/map/map.ops/find.pass.cpp
    M libcxx/test/std/containers/associative/map/map.ops/lower_bound.pass.cpp
    M libcxx/test/std/containers/associative/map/map.ops/upper_bound.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.cons/iter_iter.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.cons/iter_iter_comp.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.cons/iter_iter_comp_alloc.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.cons/move.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.modifiers/emplace.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.modifiers/emplace_hint.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.modifiers/erase_iter.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.modifiers/erase_iter_iter.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.modifiers/erase_key.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.modifiers/insert_iter_iter.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.ops/equal_range.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.ops/find.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.ops/lower_bound.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.ops/upper_bound.pass.cpp
    M libcxx/test/std/containers/associative/multiset/emplace.pass.cpp
    M libcxx/test/std/containers/associative/multiset/emplace_hint.pass.cpp
    M libcxx/test/std/containers/associative/multiset/equal_range.pass.cpp
    M libcxx/test/std/containers/associative/multiset/erase_iter.pass.cpp
    M libcxx/test/std/containers/associative/multiset/erase_iter_iter.pass.cpp
    M libcxx/test/std/containers/associative/multiset/erase_key.pass.cpp
    M libcxx/test/std/containers/associative/multiset/find.pass.cpp
    M libcxx/test/std/containers/associative/multiset/insert_iter_iter.pass.cpp
    M libcxx/test/std/containers/associative/multiset/lower_bound.pass.cpp
    M libcxx/test/std/containers/associative/multiset/multiset.cons/copy.pass.cpp
    M libcxx/test/std/containers/associative/multiset/multiset.cons/copy_alloc.pass.cpp
    M libcxx/test/std/containers/associative/multiset/multiset.cons/copy_assign.pass.cpp
    M libcxx/test/std/containers/associative/multiset/multiset.cons/iter_iter.pass.cpp
    M libcxx/test/std/containers/associative/multiset/multiset.cons/iter_iter_alloc.pass.cpp
    M libcxx/test/std/containers/associative/multiset/multiset.cons/iter_iter_comp.pass.cpp
    M libcxx/test/std/containers/associative/multiset/multiset.cons/move.pass.cpp
    M libcxx/test/std/containers/associative/multiset/upper_bound.pass.cpp
    M libcxx/test/std/containers/associative/set/emplace.pass.cpp
    M libcxx/test/std/containers/associative/set/emplace_hint.pass.cpp
    M libcxx/test/std/containers/associative/set/equal_range.pass.cpp
    M libcxx/test/std/containers/associative/set/erase_iter.pass.cpp
    M libcxx/test/std/containers/associative/set/erase_iter_iter.pass.cpp
    M libcxx/test/std/containers/associative/set/erase_key.pass.cpp
    M libcxx/test/std/containers/associative/set/find.pass.cpp
    M libcxx/test/std/containers/associative/set/insert_iter_iter.pass.cpp
    M libcxx/test/std/containers/associative/set/lower_bound.pass.cpp
    M libcxx/test/std/containers/associative/set/set.cons/copy.pass.cpp
    M libcxx/test/std/containers/associative/set/set.cons/copy_alloc.pass.cpp
    M libcxx/test/std/containers/associative/set/set.cons/copy_assign.pass.cpp
    M libcxx/test/std/containers/associative/set/set.cons/iter_iter.pass.cpp
    M libcxx/test/std/containers/associative/set/set.cons/iter_iter_alloc.pass.cpp
    M libcxx/test/std/containers/associative/set/set.cons/iter_iter_comp.pass.cpp
    M libcxx/test/std/containers/associative/set/set.cons/move.pass.cpp
    M libcxx/test/std/containers/associative/set/upper_bound.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/emplace_after.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/emplace_front.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/erase_after_many.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/erase_after_one.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/insert_after_const.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/insert_after_init.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/insert_after_range.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/insert_after_rv.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/insert_after_size_value.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/push_front_const.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/push_front_rv.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/resize_size.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/resize_size_value.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/splice_after_flist.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/splice_after_one.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/splice_after_range.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.spec/member_swap.pass.cpp
    M libcxx/test/std/containers/sequences/forwardlist/forwardlist.spec/non_member_swap.pass.cpp
    M libcxx/test/std/containers/sequences/list/list.modifiers/erase_iter.pass.cpp
    M libcxx/test/std/containers/sequences/list/list.modifiers/erase_iter_iter.pass.cpp
    M libcxx/test/std/containers/sequences/list/list.modifiers/insert_iter_initializer_list.pass.cpp
    M libcxx/test/std/containers/sequences/list/list.modifiers/insert_iter_size_value.pass.cpp
    M libcxx/test/std/containers/sequences/list/list.modifiers/insert_iter_value.pass.cpp
    M libcxx/test/std/containers/sequences/list/list.ops/splice_pos_list.pass.cpp
    M libcxx/test/std/containers/sequences/list/list.ops/splice_pos_list_iter.pass.cpp
    M libcxx/test/std/containers/sequences/list/list.ops/splice_pos_list_iter_iter.pass.cpp
    M libcxx/test/std/containers/sequences/vector.bool/erase_iter.pass.cpp
    M libcxx/test/std/containers/sequences/vector.bool/erase_iter_iter.pass.cpp
    M libcxx/test/std/containers/sequences/vector/vector.modifiers/erase_iter.pass.cpp
    M libcxx/test/std/containers/sequences/vector/vector.modifiers/erase_iter_iter.pass.cpp
    M libcxx/test/std/containers/unord/unord.map/unord.map.modifiers/erase_range.pass.cpp
    M libcxx/test/std/containers/unord/unord.multimap/reserve.pass.cpp
    M libcxx/test/std/containers/unord/unord.multimap/swap_member.pass.cpp
    M libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/emplace_hint.pass.cpp
    M libcxx/test/std/containers/unord/unord.multimap/unord.multimap.modifiers/erase_range.pass.cpp
    M libcxx/test/std/containers/unord/unord.multiset/erase_range.pass.cpp
    M libcxx/test/std/containers/unord/unord.set/erase_range.pass.cpp

  Log Message:
  -----------
  [libc++] [test] Qualify `next` as `std::next` in a lot of tests. NFCI.

We shouldn't be calling `next` via ADL -- and neither should anybody
in the wild be calling it via ADL, so it's not like we need to test
this ADL ability of `next` in particular.

Reviewed as part of D119860.


  Commit: 3b966c1fe9bf4ff398b2cc232d39f162663bfbcb
      https://github.com/llvm/llvm-project/commit/3b966c1fe9bf4ff398b2cc232d39f162663bfbcb
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2022-02-16 (Wed, 16 Feb 2022)

  Changed paths:
    M libcxx/test/std/containers/associative/map/map.modifiers/insert_cv.pass.cpp
    M libcxx/test/std/containers/associative/map/map.modifiers/insert_iter_cv.pass.cpp
    M libcxx/test/std/containers/associative/map/map.modifiers/insert_iter_rv.pass.cpp
    M libcxx/test/std/containers/associative/map/map.modifiers/insert_rv.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.modifiers/erase_iter.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.modifiers/insert_cv.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.modifiers/insert_iter_cv.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.modifiers/insert_iter_rv.pass.cpp
    M libcxx/test/std/containers/associative/multimap/multimap.modifiers/insert_rv.pass.cpp
    M libcxx/test/std/containers/associative/multiset/insert_cv.pass.cpp
    M libcxx/test/std/containers/associative/multiset/insert_iter_cv.pass.cpp
    M libcxx/test/std/containers/associative/multiset/insert_iter_rv.pass.cpp
    M libcxx/test/std/containers/associative/multiset/insert_rv.pass.cpp
    M libcxx/test/std/containers/associative/set/insert_cv.pass.cpp
    M libcxx/test/std/containers/associative/set/insert_iter_cv.pass.cpp
    M libcxx/test/std/containers/associative/set/insert_iter_rv.pass.cpp
    M libcxx/test/std/containers/associative/set/insert_rv.pass.cpp

  Log Message:
  -----------
  [libc++] [test] Qualify `prev` as `std::prev` in a lot of tests. NFCI.

We shouldn't be calling `prev` via ADL -- and neither should anybody
in the wild be calling it via ADL, so it's not like we need to test
this ADL ability of `prev` in particular.

Reviewed as part of D119860.


  Commit: 85a92deb590e3d002c41c93fb5f70429a41e96fc
      https://github.com/llvm/llvm-project/commit/85a92deb590e3d002c41c93fb5f70429a41e96fc
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2022-02-16 (Wed, 16 Feb 2022)

  Changed paths:
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_en_US.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_ru_RU.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_zh_CN.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_string_en_US.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_en_US.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_fr_FR.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_ru_RU.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_zh_CN.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_string_en_US.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_bool.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_long.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_unsigned_long.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_unsigned_long_long.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_bool.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_double.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_float.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long_double.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long_long.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_unsigned_int.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_unsigned_long.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_unsigned_long_long.pass.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_unsigned_short.pass.cpp

  Log Message:
  -----------
  [libc++] [test] Qualify calls to iomanip functions in std/localization/. NFCI.

Reviewed as part of D119860.


  Commit: eae745c18e2e432b238b8e8b69726b2ea9aeaf7b
      https://github.com/llvm/llvm-project/commit/eae745c18e2e432b238b8e8b69726b2ea9aeaf7b
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2022-02-16 (Wed, 16 Feb 2022)

  Changed paths:
    M libcxx/test/std/input.output/iostream.format/ext.manip/put_money.pass.cpp
    M libcxx/test/std/input.output/iostream.format/input.streams/istream.manip/ws.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/bool.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/double.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/float.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/int.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/long.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/long_double.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/long_long.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/short.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/unsigned_int.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/unsigned_long.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/unsigned_long_long.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/unsigned_short.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/CharT.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/CharT_pointer.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/char.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/char_pointer.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/char_to_wide.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/char_to_wide_pointer.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/signed_char.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/signed_char_pointer.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/unsigned_char.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.character/unsigned_char_pointer.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.manip/endl.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.manip/ends.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream.manip/flush.pass.cpp
    M libcxx/test/std/input.output/iostream.format/output.streams/ostream_sentry/destruct.pass.cpp

  Log Message:
  -----------
  [libc++] [test] Qualify calls to iomanip functions in std/input.output/iostream.format/. NFCI.

Reviewed as part of D119860.


  Commit: 98bb747c8705236ece7fc76a3d243b2c3c695ad5
      https://github.com/llvm/llvm-project/commit/98bb747c8705236ece7fc76a3d243b2c3c695ad5
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2022-02-16 (Wed, 16 Feb 2022)

  Changed paths:
    M libcxx/test/std/strings/basic.string/string.nonmembers/string.io/get_line.pass.cpp
    M libcxx/test/std/strings/basic.string/string.nonmembers/string.io/get_line_delim.pass.cpp
    M libcxx/test/std/strings/basic.string/string.nonmembers/string.io/get_line_delim_rv.pass.cpp
    M libcxx/test/std/strings/basic.string/string.nonmembers/string.io/get_line_rv.pass.cpp

  Log Message:
  -----------
  [libc++] [test] Qualify calls to std::getline. NFCI.

Reviewed as part of D119860.


  Commit: f033bf88b4e22795dba19235b299ceebd34449b7
      https://github.com/llvm/llvm-project/commit/f033bf88b4e22795dba19235b299ceebd34449b7
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2022-02-16 (Wed, 16 Feb 2022)

  Changed paths:
    M libcxx/test/std/atomics/atomics.flag/atomic_flag_clear.pass.cpp
    M libcxx/test/std/atomics/atomics.flag/atomic_flag_clear_explicit.pass.cpp
    M libcxx/test/std/atomics/atomics.flag/atomic_flag_test.pass.cpp
    M libcxx/test/std/atomics/atomics.flag/atomic_flag_test_and_set.pass.cpp
    M libcxx/test/std/atomics/atomics.flag/atomic_flag_test_and_set_explicit.pass.cpp
    M libcxx/test/std/atomics/atomics.flag/atomic_flag_test_explicit.pass.cpp

  Log Message:
  -----------
  [libc++] [test] Qualify calls to std::atomic_flag_{clear,test} functions. NFCI.

We shouldn't be calling these functions via ADL -- and neither should anybody
in the wild be calling it via ADL, so it's not like we need to test
the ADL ability of these functions in particular.

Reviewed as part of D119860.


  Commit: 79dc7551d83b0aa95366fdac64cd06367d75a088
      https://github.com/llvm/llvm-project/commit/79dc7551d83b0aa95366fdac64cd06367d75a088
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2022-02-16 (Wed, 16 Feb 2022)

  Changed paths:
    M libcxx/test/std/language.support/support.exception/except.nested/assign.pass.cpp
    M libcxx/test/std/language.support/support.exception/except.nested/ctor_copy.pass.cpp
    M libcxx/test/std/language.support/support.exception/except.nested/ctor_default.pass.cpp

  Log Message:
  -----------
  [libc++] [test] Qualify calls to std::rethrow_exception. NFC.

We shouldn't be calling `rethrow_exception` via ADL -- and neither should anybody
in the wild be calling it via ADL, so it's not like we need to test
this ADL ability of `rethrow_exception` in particular.

Reviewed as part of D119860.


  Commit: 37f7e31015b0e025f0f72e6146b25269662ad282
      https://github.com/llvm/llvm-project/commit/37f7e31015b0e025f0f72e6146b25269662ad282
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2022-02-16 (Wed, 16 Feb 2022)

  Changed paths:
    M libcxx/test/std/ranges/range.utility/range.subrange/ctor.pair_like_conv.pass.cpp

  Log Message:
  -----------
  [libc++] [test] Qualify calls to std::get(tuple). NFC.

It actually *is* important (for structured bindings) that `get(tuple)`
be ADL-able; but that's not the point of this test in particular.

Reviewed as part of D119860.


Compare: https://github.com/llvm/llvm-project/compare/3f3abaf40ad5...37f7e31015b0


More information about the All-commits mailing list