[all-commits] [llvm/llvm-project] c9032f: [LowerMemIntrinsics] Explicitly use i8 type in mem...

Nikita Popov via All-commits all-commits at lists.llvm.org
Wed Feb 16 07:32:15 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c9032f1a69ed2a5368a5ef783ff4a5c641e86565
      https://github.com/llvm/llvm-project/commit/c9032f1a69ed2a5368a5ef783ff4a5c641e86565
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-02-16 (Wed, 16 Feb 2022)

  Changed paths:
    M llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp

  Log Message:
  -----------
  [LowerMemIntrinsics] Explicitly use i8 type in memmove lowering

By convention, memcpy/memmove intrinsics are always used with i8
pointers (though this is not enforced), so in practice this code
was always using an i8 type. Make that explicit.

Of course, i8 is not a very profitable choice, and this code could
be more performant by picking an appropriate larger type. But that
would require additional test coverage and correctness review, and
certainly shouldn't be a decision based on the pointer element type.




More information about the All-commits mailing list