[all-commits] [llvm/llvm-project] 94c28d: [lld-macho][nfc] Factor out callgraph parsing code

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 94c28d289aec0ceb2b774152f405123076918095
      https://github.com/llvm/llvm-project/commit/94c28d289aec0ceb2b774152f405123076918095
  Author: Jez Ng <jezng at fb.com>
  Date:   2022-02-15 (Tue, 15 Feb 2022)

  Changed paths:
    M lld/MachO/InputFiles.cpp
    M lld/MachO/InputFiles.h
    M lld/MachO/InputSection.h

  Log Message:
  -----------
  [lld-macho][nfc] Factor out callgraph parsing code

`parseSections()` is a getting a bit large unwieldy, let's factor out
logic where we can.

Other minor changes in this diff:
* `"__cg_profile"` is now a global constexpr
* We now use `checkError()` instead of `fatal()`-ing without handling
  the Error
* Check for `callGraphProfileSort` before checking the section name,
  since the boolean comparison is likely cheaper

Reviewed By: #lld-macho, lgrey, oontvoo

Differential Revision: https://reviews.llvm.org/D119892