[all-commits] [llvm/llvm-project] a76654: Update the diagnostic behavior of [[noreturn]] in C2x

Aaron Ballman via All-commits all-commits at lists.llvm.org
Mon Feb 14 11:05:07 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a766545402d8569532294d097d026cf2e837b5c2
      https://github.com/llvm/llvm-project/commit/a766545402d8569532294d097d026cf2e837b5c2
  Author: Aaron Ballman <aaron at aaronballman.com>
  Date:   2022-02-14 (Mon, 14 Feb 2022)

  Changed paths:
    M clang/lib/Headers/stdnoreturn.h
    M clang/lib/Sema/SemaDeclAttr.cpp
    M clang/test/Sema/c2x-noreturn.c

  Log Message:
  -----------
  Update the diagnostic behavior of [[noreturn]] in C2x

Post-commit review feedback suggested dropping the deprecated
diagnostic for the 'noreturn' macro (the diagnostic from the header
file suffices and the macro diagnostic could be confusing) and to only
issue the deprecated diagnostic for [[_Noreturn]] when the attribute
identifier is either directly written or not from a system macro.

Amends the commit made in 5029dce492b3cf3ac191eda0b5bf268c3acac2e0.




More information about the All-commits mailing list