[all-commits] [llvm/llvm-project] 779bbb: [lldb] Replace asserts on .Success() with assertSu...

[Dave Lee via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 779bbbf27fe631154bdfaac7a443f198d4654688
      https://github.com/llvm/llvm-project/commit/779bbbf27fe631154bdfaac7a443f198d4654688
  Author: Dave Lee <davelee.com at gmail.com>
  Date:   2022-02-14 (Mon, 14 Feb 2022)

  Changed paths:
    M lldb/test/API/commands/expression/context-object-objc/TestContextObjectObjc.py
    M lldb/test/API/commands/platform/basic/TestPlatformPython.py
    M lldb/test/API/commands/watchpoints/multiple_hits/TestMultipleHits.py
    M lldb/test/API/commands/watchpoints/step_over_watchpoint/TestStepOverWatchpoint.py
    M lldb/test/API/functionalities/breakpoint/auto_continue/TestBreakpointAutoContinue.py
    M lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommandsFromPython.py
    M lldb/test/API/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
    M lldb/test/API/functionalities/breakpoint/serialize/TestBreakpointSerialization.py
    M lldb/test/API/functionalities/dlopen_other_executable/TestDlopenOtherExecutable.py
    M lldb/test/API/functionalities/dyld-launch-linux/TestDyldLaunchLinux.py
    M lldb/test/API/functionalities/gdb_remote_client/TestGDBRemoteClient.py
    M lldb/test/API/functionalities/gdb_remote_client/TestJLink6Armv7RegisterDefinition.py
    M lldb/test/API/functionalities/gdb_remote_client/TestMemoryRegionDirtyPages.py
    M lldb/test/API/functionalities/launch_stop_at_entry/TestStopAtEntry.py
    M lldb/test/API/functionalities/load_using_paths/TestLoadUsingPaths.py
    M lldb/test/API/functionalities/paths/TestPaths.py
    M lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py
    M lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
    M lldb/test/API/functionalities/postmortem/minidump/TestMiniDump.py
    M lldb/test/API/functionalities/process_crash_info/TestProcessCrashInfo.py
    M lldb/test/API/functionalities/process_save_core/TestProcessSaveCore.py
    M lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py
    M lldb/test/API/functionalities/return-value/TestReturnValue.py
    M lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
    M lldb/test/API/functionalities/scripted_process/TestStackCoreScriptedProcess.py
    M lldb/test/API/functionalities/step_scripted/TestStepScripted.py
    M lldb/test/API/functionalities/thread/exit_during_expression/TestExitDuringExpression.py
    M lldb/test/API/functionalities/thread/state_after_expression/TestStateAfterExpression.py
    M lldb/test/API/functionalities/var_path/TestVarPath.py
    M lldb/test/API/lang/c/local_types/TestUseClosestType.py
    M lldb/test/API/lang/cpp/incomplete-types/TestCppIncompleteTypes.py
    M lldb/test/API/lang/cpp/trivial_abi/TestTrivialABI.py
    M lldb/test/API/lang/cpp/type_lookup/TestCppTypeLookup.py
    M lldb/test/API/lang/objc/blocks/TestObjCIvarsInBlocks.py
    M lldb/test/API/lang/objc/global_ptrs/TestGlobalObjects.py
    M lldb/test/API/lang/objc/objc-checker/TestObjCCheckers.py
    M lldb/test/API/lang/objc/objc-ivar-offsets/TestObjCIvarOffsets.py
    M lldb/test/API/lang/objc/objc-ivar-stripped/TestObjCIvarStripped.py
    M lldb/test/API/lang/objc/objc-property/TestObjCProperty.py
    M lldb/test/API/linux/aarch64/unwind_signal/TestUnwindSignal.py
    M lldb/test/API/macosx/function-starts/TestFunctionStarts.py
    M lldb/test/API/macosx/profile_vrs_detach/TestDetachVrsProfile.py
    M lldb/test/API/macosx/thread_suspend/TestInternalThreadSuspension.py
    M lldb/test/API/macosx/universal/TestUniversal.py
    M lldb/test/API/python_api/debugger/TestDebuggerAPI.py
    M lldb/test/API/python_api/file_handle/TestFileHandle.py
    M lldb/test/API/python_api/process/read-mem-cstring/TestReadMemCString.py
    M lldb/test/API/python_api/sbdata/TestSBData.py
    M lldb/test/API/python_api/sbmodule/TestSBModule.py
    M lldb/test/API/python_api/sbplatform/TestSBPlatform.py
    M lldb/test/API/python_api/sbstructureddata/TestStructuredDataAPI.py
    M lldb/test/API/python_api/target/TestTargetAPI.py
    M lldb/test/API/python_api/value/change_values/TestChangeValueAPI.py
    M lldb/test/API/sample_test/TestSampleTest.py
    M lldb/test/API/sample_test/main.c

  Log Message:
  -----------
  [lldb] Replace asserts on .Success() with assertSuccess()

Replace forms of `assertTrue(err.Success())` with `assertSuccess(err)` (added in D82759).

* `assertSuccess` prints out the error's message
* `assertSuccess` expresses explicit higher level semantics, both to the reader and for test failure output
* `assertSuccess` seems not to be well known, using it where possible will help spread knowledge
* `assertSuccess` statements are more succinct

Differential Revision: https://reviews.llvm.org/D119616