[all-commits] [llvm/llvm-project] 880e87: [demangler][NFC] Tweak legacy uuidof handling

Nathan Sidwell via All-commits all-commits at lists.llvm.org
Mon Feb 14 04:12:42 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 880e87580a219996f96ebf2cc9be9740f1a99a4c
      https://github.com/llvm/llvm-project/commit/880e87580a219996f96ebf2cc9be9740f1a99a4c
  Author: Nathan Sidwell <nathan at acm.org>
  Date:   2022-02-14 (Mon, 14 Feb 2022)

  Changed paths:
    M libcxxabi/src/demangle/ItaniumDemangle.h
    M llvm/include/llvm/Demangle/ItaniumDemangle.h

  Log Message:
  -----------
  [demangler][NFC] Tweak legacy uuidof handling

We have to special-case 'u 8__uuidof [tz]' demangling for legacy
support.  That handling is a little duplicative.

* It seems better to just push the single expected node.

* We can also use 'consumeIf' rather than open-coding the peeking and increment.

* We don't need the numLeft < 2 check, as if there are few than that
  other paths will end up with detecting the error.

FWIW This simplifies a future change adding operator precedence.

Reviewed By: ChuanqiXu

Differential Revision: https://reviews.llvm.org/D119543




More information about the All-commits mailing list