[all-commits] [llvm/llvm-project] 83028a: [clang][AST][ASTImporter] Set record to complete d...

Balázs Kéri via All-commits all-commits at lists.llvm.org
Sun Feb 13 23:28:31 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 83028ad934d60b024b5b0272cb68523232715dab
  Author: Balázs Kéri <1.int32 at gmail.com>
  Date:   2022-02-14 (Mon, 14 Feb 2022)

  Changed paths:
    M clang/lib/AST/ASTImporter.cpp
    M clang/unittests/AST/ASTImporterTest.cpp

  Log Message:
  [clang][AST][ASTImporter] Set record to complete during import of its members.

At import of a member it may require that the record is already set to complete.
(For example 'computeDependence' at create of some Expr nodes.)
The record at this time may not be completely imported, the result of layout
calculations can be incorrect, but at least no crash occurs this way.

A good solution would be if fields of every encountered record are imported
before other members of all records. This is much more difficult to implement.

Differential Revision: https://reviews.llvm.org/D116155

More information about the All-commits mailing list