[all-commits] [llvm/llvm-project] 96b7e0: [SDAG] clean up scalarizing load transform

Sanjay Patel via All-commits all-commits at lists.llvm.org
Sat Feb 12 08:46:03 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 96b7e0b5a0c6bd5742af783ed83cc41c299e9472
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-02-12 (Sat, 12 Feb 2022)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

  Log Message:
  [SDAG] clean up scalarizing load transform

I have not found a way to expose a difference for this patch in a test
because it only triggers for a one-use load, but this is the code that
was adapted into D118376 and caused miscompiles. The new code pattern
is the same as what we do in narrowExtractedVectorLoad() (reduces load
width for a subvector extract).

This removes seemingly unnecessary manual worklist management and fixes
the chain updating via "SelectionDAG::makeEquivalentMemoryOrdering()".

Differential Revision: https://reviews.llvm.org/D119549

More information about the All-commits mailing list