[all-commits] [llvm/llvm-project] a9f1a9: [compiler-rt] Force ABI to libcxxabi when building...

Dimitry Andric via All-commits all-commits at lists.llvm.org
Fri Feb 11 13:14:07 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a9f1a9c00af3badc991028b313fcc701599c8ac2
  Author: Dimitry Andric <dimitry at andric.com>
  Date:   2022-02-11 (Fri, 11 Feb 2022)

  Changed paths:
    M compiler-rt/cmake/Modules/AddCompilerRT.cmake

  Log Message:
  [compiler-rt] Force ABI to libcxxabi when building cxustom libc++

Follow-up to 458ead66dc37, which replaced the bespoke CMakeLists.txt
file for building a custom instrumented libc++ with an invocation of the
runtimes build.

In the the bespoke CMakeLists.txt, the LIBCXX_CXX_ABI setting was forced
to libcxxabi, but this was not done for the CMake invocation for the
runtimes build. This would cause CMake configuration issues on platforms
where the default LIBCXX_CXX_ABI setting is not libcxxabi, such as

Add `-DLIBCXX_CXX_ABI=libcxxabi` to that invocation, to make sure the
custom instrumented libc++ always uses the expected ABI.

Reviewed By: phosek

Differential Revision: https://reviews.llvm.org/D119554

More information about the All-commits mailing list