[all-commits] [llvm/llvm-project] ef764e: [lld-macho][nfc] Centralize usages of ld64.lld in ...

Vincent Lee via All-commits all-commits at lists.llvm.org
Thu Feb 10 17:27:35 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ef764ee207468c4e9c7221db25cdbc55c38315a9
  Author: Vincent Lee <leevince at fb.com>
  Date:   2022-02-10 (Thu, 10 Feb 2022)

  Changed paths:
    M lld/test/MachO/adhoc-codesign.s
    M lld/test/MachO/invalid/stub-link.s
    M lld/test/MachO/lit.local.cfg
    M lld/test/MachO/reproduce.s
    M lld/test/MachO/reroot-path.s
    M lld/test/MachO/search-paths-darwin.test
    M lld/test/MachO/skip-platform-checks.s
    M lld/test/MachO/syslibroot.test

  Log Message:
  [lld-macho][nfc] Centralize usages of ld64.lld in tests

We have a mix of substituted lld (`%lld`) and hard-coded lld (`ld64.lld`) commands.
When testing with different versions of LLD, this would require going into every place
where lld is hard-coded and changing that. If we centralize it, this'll only  require us
to modify it in only one place and will make it easy to run the same test suite. Plus,
this will make it be consistent with how we write other tests.

Reviewed By: #lld-macho, int3, oontvoo

Differential Revision: https://reviews.llvm.org/D119394

More information about the All-commits mailing list