[all-commits] [llvm/llvm-project] 389f67: DebugInfo: Don't simplify names referencing local ...

David Blaikie via All-commits all-commits at lists.llvm.org
Thu Feb 10 15:54:40 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 389f67b35b0e99892a8f6c94787b054f26c8d4e2
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2022-02-10 (Thu, 10 Feb 2022)

  Changed paths:
    M clang/lib/CodeGen/CGDebugInfo.cpp
    M clang/test/CodeGenCXX/debug-info-simple-template-names.cpp
    M cross-project-tests/debuginfo-tests/clang_llvm_roundtrip/simplified_template_names.cpp

  Log Message:
  DebugInfo: Don't simplify names referencing local enums

Due to the way type units work, this would lead to a declaration in a
type unit of a local type in a CU - which is ambiguous. Rather than
trying to resolve that relative to the CU that references the type unit,
let's just not try to simplify these names.

Longer term this should be fixed by not putting the template
instantiation in a type unit to begin with - since it references an
internal linkage type, it can't legitimately be duplicated/in more than
one translation unit, so skip the type unit overhead. (but the right fix
for that is to move type unit management into a DICompositeType flag
(dropping the "identifier" field is not a perfect solution since it
breaks LLVM IR linking decl/def merging during IR linking))

More information about the All-commits mailing list