[all-commits] [llvm/llvm-project] f3a2cf: DebugInfo: Don't simplify any template referencing...

David Blaikie via All-commits all-commits at lists.llvm.org
Thu Feb 10 14:57:12 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f3a2cfc10394143bbe30a6af00be8b68c1c0d607
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2022-02-10 (Thu, 10 Feb 2022)

  Changed paths:
    M clang/lib/CodeGen/CGDebugInfo.cpp
    M clang/test/CodeGenCXX/debug-info-simple-template-names.cpp
    M cross-project-tests/debuginfo-tests/clang_llvm_roundtrip/simplified_template_names.cpp
    A cross-project-tests/debuginfo-tests/clang_llvm_roundtrip/simplified_template_names_noncanonical_type_units.cpp

  Log Message:
  DebugInfo: Don't simplify any template referencing a lambda

Lambda names aren't entirely canonical (as demonstrated by the
cross-project-test added here) at the moment (we should fix that for a
bunch of reasons) - even if the template referencing them is
non-simplified, other names referencing /that/ template can't be
simplified either because type units might cause a different template to
be picked up that would conflict with the expected name.

(other than for roundtripping precision, it'd be OK to simplify types
that reference types that reference lambdas - but best be consistent
between the roundtrip/verify mode and the actual simplified template
names mode)

More information about the All-commits mailing list