[all-commits] [llvm/llvm-project] d6b144: [libc++] Remove usage of `_LIBCPP_DEBUG` in `__com...

Jordan Rupprecht via All-commits all-commits at lists.llvm.org
Thu Feb 10 09:04:49 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d6b1448809e4c6a2a5eca262bb917d5e76cf5206
  Author: Jordan Rupprecht <rupprecht at google.com>
  Date:   2022-02-10 (Thu, 10 Feb 2022)

  Changed paths:
    M libcxx/include/__algorithm/comp_ref_type.h

  Log Message:
  [libc++] Remove usage of `_LIBCPP_DEBUG` in `__comp_ref_type` and replace with `_LIBCPP_DEBUG_LEVEL`

In libc++, checking specific `_LIBCPP_DEBUG_LEVEL` levels is used everywhere except in `comp_ref_type.h`. `_LIBCPP_DEBUG` is meant as a user-facing option, and internally libc++ should be checking the value of `_LIBCPP_DEBUG_LEVEL`.

The definition of `std::__debug_less` doesn't need to be hidden behind the macro, we can unconditionally expose it. It will be unused by `__comp_ref_type` unless debug mode is enabled.

This was suggested in D118940.

Reviewed By: #libc, philnik, Quuxplusone, ldionne

Differential Revision: https://reviews.llvm.org/D118950

More information about the All-commits mailing list