[all-commits] [llvm/llvm-project] ff0b39: [NVPTX] Remove image/sampler special case in call ...

Nikita Popov via All-commits all-commits at lists.llvm.org
Wed Feb 9 00:40:42 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ff0b391600c77ca05a262bcca9e3d26aa333cfd0
      https://github.com/llvm/llvm-project/commit/ff0b391600c77ca05a262bcca9e3d26aa333cfd0
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp

  Log Message:
  -----------
  [NVPTX] Remove image/sampler special case in call lowering

I suspect that this is dead code. There is no test coverage for
this special case, and the struct type names this checks against
don't seem to match what OpenCL actually generates (which would be
%opencl.sampler_t rather than %struct._sampler_t for example).

Motivation for this change is that this code is incompatible with
opaque pointers -- simply deleting it is the simplest way of
making it compatible :)

Differential Revision: https://reviews.llvm.org/D119229




More information about the All-commits mailing list