[all-commits] [llvm/llvm-project] bbddd1: [mlir][math] Expand coverage of atan2 expansion

Jacques Pienaar via All-commits all-commits at lists.llvm.org
Tue Feb 8 15:00:56 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bbddd19ec723a15ea1558cce5e47cb2460fa8e24
  Author: Jacques Pienaar <jpienaar at google.com>
  Date:   2022-02-08 (Tue, 08 Feb 2022)

  Changed paths:
    M mlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp
    M mlir/test/Dialect/Math/polynomial-approximation.mlir

  Log Message:
  [mlir][math] Expand coverage of atan2 expansion

Reuse the higher precision F32 approximation for the F16 one (by expanding and
truncating). This is partly RFC as I'm not sure what the expectations are here
(e.g., these are only for F32 and should not be expanded, that reusing
higher-precision ones for lower precision is undesirable due to increased
compute cost and only approximations per exact type is preferred, or this is
appropriate [at least as fallback] but we need to see how to make it more
generic across all the patterns here).

Differential Revision: https://reviews.llvm.org/D118968

More information about the All-commits mailing list