[all-commits] [llvm/llvm-project] f05a63: [clang] Properly cache member pointer LLVM types

aeubanks via All-commits all-commits at lists.llvm.org
Tue Feb 8 13:22:42 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f05a63f9a09bdacab6a98683c5a4fc3f1f2a9149
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2022-02-08 (Tue, 08 Feb 2022)

  Changed paths:
    M clang/lib/CodeGen/CodeGenTypes.cpp
    M clang/lib/CodeGen/CodeGenTypes.h
    M clang/test/CodeGenCXX/type-cache-2.cpp
    M clang/test/CodeGenCXX/type-cache-3.cpp
    M clang/test/CodeGenCXX/type-cache.cpp

  Log Message:
  [clang] Properly cache member pointer LLVM types

When not going through the main Clang->LLVM type cache, we'd
accidentally create multiple different opaque types for a member pointer

This allows us to remove the -verify-type-cache flag now that
check-clang passes with it on. We can do the verification in expensive
builds. Previously microsoft-abi-member-pointers.cpp was failing with

I suspect that there may be more issues when we have multiple member
pointer types and we clear the cache, but we can leave that for later.

Followup to D118744.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D119215

More information about the All-commits mailing list