[all-commits] [llvm/llvm-project] 4669cc: [test][llvm-objcopy/mac] Fix invalid strip tests

Keith Smiley via All-commits all-commits at lists.llvm.org
Mon Feb 7 20:07:02 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4669cc93948e6d058812fc2f8f888dc478f09b33
      https://github.com/llvm/llvm-project/commit/4669cc93948e6d058812fc2f8f888dc478f09b33
  Author: Keith Smiley <keithbsmiley at gmail.com>
  Date:   2022-02-07 (Mon, 07 Feb 2022)

  Changed paths:
    M llvm/test/tools/llvm-objcopy/MachO/Inputs/strip-chained-fixups.yaml
    M llvm/test/tools/llvm-objcopy/MachO/strip-all.test

  Log Message:
  -----------
  [test][llvm-objcopy/mac] Fix invalid strip tests

I discovered some of these tests had `cmp` statements that weren't
actually being run. I had also recently copied this broken setup for a
new test around chained fixups. Fixing this revealed that the binaries
did differ because of their code signature so I regenerated the fixture
here with this source:

```c
int main() {
   return 0;
}
```

Passing `-Wl,-no_adhoc_codesign` on my M1 machine to make sure it didn't
get any signature.

Differential Revision: https://reviews.llvm.org/D119203




More information about the All-commits mailing list