[all-commits] [llvm/llvm-project] f8d889: [lldb] Print message after loading 'crashlog' command

Dave Lee via All-commits all-commits at lists.llvm.org
Mon Feb 7 12:35:15 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f8d889a789e2ac7012d202971d4e214d0b13949c
      https://github.com/llvm/llvm-project/commit/f8d889a789e2ac7012d202971d4e214d0b13949c
  Author: Dave Lee <davelee.com at gmail.com>
  Date:   2022-02-07 (Mon, 07 Feb 2022)

  Changed paths:
    M lldb/examples/python/crashlog.py
    M lldb/test/Shell/Heap/heap-cstr.test
    M lldb/test/Shell/ScriptInterpreter/Python/Crashlog/json.test
    M lldb/test/Shell/ScriptInterpreter/Python/Crashlog/no_threadState.test
    M lldb/test/Shell/ScriptInterpreter/Python/Crashlog/text.test

  Log Message:
  -----------
  [lldb] Print message after loading 'crashlog' command

Previously, importing `crashlog` resulted in a message being printed. The
message was about other commands (those in heap.py), not `crashlog`. The
changes in D117237 made it so that the heap.py messages were printed only when
importing `lldb.macosx.heap`, not when importing `lldb.macosx.crashlog`. Some
users may see no output and think `crashlog` wasn't successfully loaded. This
ensures users see that `crashlog` is loaded.

rdar://88283132

Differential Revision: https://reviews.llvm.org/D119155




More information about the All-commits mailing list