[all-commits] [llvm/llvm-project] b4626f: [mlir] Do not use an empty source file when buildi...

Stella Laurenzo via All-commits all-commits at lists.llvm.org
Sat Feb 5 23:06:47 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b4626f22defa4046991caa146cbbf0e792b43e92
      https://github.com/llvm/llvm-project/commit/b4626f22defa4046991caa146cbbf0e792b43e92
  Author: Stella Laurenzo <stellaraccident at gmail.com>
  Date:   2022-02-05 (Sat, 05 Feb 2022)

  Changed paths:
    M mlir/cmake/modules/AddMLIR.cmake

  Log Message:
  -----------
  [mlir] Do not use an empty source file when building aggregate libraries.

See discussion: https://discourse.llvm.org/t/check-mlir-times-examples-standalone-testing-time/6073/7

It turns out that it has been legal since CMake 3.11 to omit sources at library creation time if they are added later via target_sources, as is done here. This side-steps the issue of having a file that changes and invalidates the build of leaves.

Differential Revision: https://reviews.llvm.org/D119069




More information about the All-commits mailing list