[all-commits] [llvm/llvm-project] f5e1ac: [NFC] Move FoldingSetNodeID::AddInteger and Foldin...

yurai007 via All-commits all-commits at lists.llvm.org
Thu Feb 3 06:35:54 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f5e1ace9b08d351df72cb15ccced169cd8d3ea93
      https://github.com/llvm/llvm-project/commit/f5e1ace9b08d351df72cb15ccced169cd8d3ea93
  Author: Dawid Jurczak <dawid_jurek at vp.pl>
  Date:   2022-02-03 (Thu, 03 Feb 2022)

  Changed paths:
    M llvm/include/llvm/ADT/FoldingSet.h
    M llvm/lib/Support/FoldingSet.cpp

  Log Message:
  -----------
  [NFC] Move FoldingSetNodeID::AddInteger and FoldingSetNodeID::AddPointer definitions to header

Lack of AddInteger/AddPointer inlining slows down NodeEquals/Profile/:operator== calls.
Inlining makes FunctionProtoTypes/PointerTypes/ElaboratedTypes/ParenTypes Profile functions faster
but since NodeEquals is still called indirectly through function pointer from FindNodeOrInsertPos
there is room for further inlining improvements.

Extracted from: https://reviews.llvm.org/D118385

Differential Revision: https://reviews.llvm.org/D118610




More information about the All-commits mailing list