[all-commits] [llvm/llvm-project] ee4ba9: Revert "[SimplifyCFG] Start redesigning `FoldTwoEn...

Roman Lebedev via All-commits all-commits at lists.llvm.org
Thu Feb 3 01:33:07 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ee4ba9f3a182397c60e17f14823eb22b2e5831c7
      https://github.com/llvm/llvm-project/commit/ee4ba9f3a182397c60e17f14823eb22b2e5831c7
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-02-03 (Thu, 03 Feb 2022)

  Changed paths:
    M llvm/lib/Transforms/Utils/SimplifyCFG.cpp
    M llvm/test/CodeGen/AArch64/check-sign-bit-before-extension.ll
    M llvm/test/CodeGen/AArch64/combine-comparisons-by-cse.ll
    M llvm/test/CodeGen/AArch64/typepromotion-phisret.ll
    M llvm/test/CodeGen/ARM/ifcvt-callback.ll
    M llvm/test/CodeGen/ARM/ifcvt1.ll
    M llvm/test/Transforms/PGOProfile/chr.ll
    M llvm/test/Transforms/PhaseOrdering/X86/earlycse-after-simplifycfg-two-entry-phi-node-folding.ll
    M llvm/test/Transforms/PhaseOrdering/X86/merge-functions.ll
    M llvm/test/Transforms/SimplifyCFG/UnreachableEliminate.ll
    M llvm/test/Transforms/SimplifyCFG/X86/sink-common-code.ll
    M llvm/test/Transforms/SimplifyCFG/bbi-23595.ll
    M llvm/test/Transforms/SimplifyCFG/merge-cond-stores-2.ll
    M llvm/test/Transforms/SimplifyCFG/no-md-sink.ll
    M llvm/test/Transforms/SimplifyCFG/preserve-store-alignment.ll

  Log Message:
  -----------
  Revert "[SimplifyCFG] Start redesigning `FoldTwoEntryPHINode()`."

Unfortunately, it seems we really do need to take the long route;
start from the "merge" block, find (all the) "dispatch" blocks,
and deal with each "dispatch" block separately, instead of simply
starting from each "dispatch" block like it would logically make sense,
otherwise we run into a number of other missing folds around
`switch` formation, missing sinking/hoisting and phase ordering.

This reverts commit 85628ce75b3084dc0f185a320152baf85b59aba7.
This reverts commit c5fff9095342a792bf4b9a077fe3c3a83c4e566c.
This reverts commit 34a98e1046e3aa55e5f26ab20a15e96b4034d25a.
This reverts commit 1e353f092288309d74d380367aa50bbd383780ed.




More information about the All-commits mailing list