[all-commits] [llvm/llvm-project] c0185f: [clang] Don't typo-fix an expression in a SFINAE c...

Quuxplusone via All-commits all-commits at lists.llvm.org
Tue Feb 1 12:17:49 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c0185ffaec3cb0aa7677b13a898eaa485ef29421
      https://github.com/llvm/llvm-project/commit/c0185ffaec3cb0aa7677b13a898eaa485ef29421
  Author: Arthur O'Dwyer <arthur.j.odwyer at gmail.com>
  Date:   2022-02-01 (Tue, 01 Feb 2022)

  Changed paths:
    M clang/lib/Sema/Sema.cpp
    M clang/lib/Sema/SemaExprMember.cpp
    A clang/test/SemaTemplate/pr52970.cpp

  Log Message:
  -----------
  [clang] Don't typo-fix an expression in a SFINAE context.

If this is a SFINAE context, then continuing to look up names
(in particular, to treat a non-function as a function, and then
do ADL) might too-eagerly complete a type that it's not safe to
complete right now. We should just say "okay, that's a substitution
failure" and not do any more work than absolutely required.

Fixes #52970.

Differential Revision: https://reviews.llvm.org/D117603




More information about the All-commits mailing list