[all-commits] [llvm/llvm-project] 0bc0ad: [mlir][ods] Unify Attr/TypeDef and Operation Forma...

Jeff Niu via All-commits all-commits at lists.llvm.org
Mon Jan 31 23:28:49 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0bc0ad86e2cdef3585d9c47aed66ebbe9aec4f4c
      https://github.com/llvm/llvm-project/commit/0bc0ad86e2cdef3585d9c47aed66ebbe9aec4f4c
  Author: Mogball <jeffniu22 at gmail.com>
  Date:   2022-02-01 (Tue, 01 Feb 2022)

  Changed paths:
    M mlir/test/mlir-tblgen/attr-or-type-format-invalid.td
    M mlir/test/mlir-tblgen/op-format-spec.td
    M mlir/tools/mlir-tblgen/AttrOrTypeFormatGen.cpp
    M mlir/tools/mlir-tblgen/FormatGen.cpp
    M mlir/tools/mlir-tblgen/FormatGen.h
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp

  Log Message:
  -----------
  [mlir][ods] Unify Attr/TypeDef and Operation Format Parsing

Part 2 of 3 of unifying the assembly formats of attributes/types and operations.The last patch that introduced attribute/type formats (D111594) factored out the format lexer entirely. This patch factors out most of the format parsers such that the attribute/type and op parsers only need to implement handling for specific elements.

Certain things could be factored better (element verification, 'seen' variables) but the primary goal of factoring is so that features can be used across both assembly formats.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D117971




More information about the All-commits mailing list