[all-commits] [llvm/llvm-project] eb9645: [libcxx] [Windows] Pick a unique bit for __regex_word

Martin Storsjö via All-commits all-commits at lists.llvm.org
Mon Jan 31 13:14:18 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: eb9645819c6dde35e2588b2729a847757b5875d3
      https://github.com/llvm/llvm-project/commit/eb9645819c6dde35e2588b2729a847757b5875d3
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-01-31 (Mon, 31 Jan 2022)

  Changed paths:
    M libcxx/include/__locale
    M libcxx/test/std/re/re.traits/isctype.pass.cpp
    M libcxx/test/std/re/re.traits/lookup_classname.pass.cpp

  Log Message:
  -----------
  [libcxx] [Windows] Pick a unique bit for __regex_word

The old `__regex_word` aliased the mask for `xdigit`, causing stray
test failures.

The diff may look surprising, as if the previous faulty value had
been set specifically for Windows - but this is due to a restructuring
in 411c630bae0e0d50697651797709987e2cfea92d. Prior to that, there
were OS specific settings for some OSes, and one fallback used for
the rest (which turns out to not work for Windows).

Differential Revision: https://reviews.llvm.org/D118188




More information about the All-commits mailing list