[all-commits] [llvm/llvm-project] 1a5388: [libcxx] [Windows] Use the standard vsnprintf inst...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Mon Jan 31 12:29:59 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1a5388ca67b03ca21043369f2023ffa0e9bc35dc
      https://github.com/llvm/llvm-project/commit/1a5388ca67b03ca21043369f2023ffa0e9bc35dc
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-01-31 (Mon, 31 Jan 2022)

  Changed paths:
    M libcxx/src/support/win32/support.cpp
    M libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_double.pass.cpp

  Log Message:
  -----------
  [libcxx] [Windows] Use the standard vsnprintf instead of _vsnprintf

In ancient Microsoft C runtimes, there might only have been
a nonstandard `_vsnprintf` instead of the standard `vsnprintf`, but
in modern versions (the only ones relevant for libc++), both
are available.

In MinGW configurations built with `__USE_MINGW_ANSI_STDIO=1` (as it
is built in CI), `vsnprintf` provides a more standards compliant
behaviour than what Microsoft's CRT provides, while `_vsnprintf` retains
the Microsoft C runtime specific quirks.

Differential Revision: https://reviews.llvm.org/D118187




More information about the All-commits mailing list