[all-commits] [llvm/llvm-project] 4f7352: [test][NewGVN] Use -passes=newgvn instead of -newgvn
Björn Pettersson via All-commits
all-commits at lists.llvm.org
Fri Jan 28 04:59:14 PST 2022
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 4f73528403944627c5d13f57ee7728c7f92b3c47
https://github.com/llvm/llvm-project/commit/4f73528403944627c5d13f57ee7728c7f92b3c47
Author: Bjorn Pettersson <bjorn.a.pettersson at ericsson.com>
Date: 2022-01-28 (Fri, 28 Jan 2022)
Changed paths:
M llvm/test/Transforms/InstSimplify/ConstProp/gep-constanfolding-error.ll
M llvm/test/Transforms/NewGVN/2007-07-25-DominatedLoop.ll
M llvm/test/Transforms/NewGVN/2007-07-25-Loop.ll
M llvm/test/Transforms/NewGVN/2007-07-25-NestedLoop.ll
M llvm/test/Transforms/NewGVN/2007-07-25-SinglePredecessor.ll
M llvm/test/Transforms/NewGVN/2007-07-26-NonRedundant.ll
M llvm/test/Transforms/NewGVN/2007-07-26-PhiErasure.ll
M llvm/test/Transforms/NewGVN/2007-07-30-PredIDom.ll
M llvm/test/Transforms/NewGVN/2008-02-12-UndefLoad-xfail.ll
M llvm/test/Transforms/NewGVN/2008-02-13-NewPHI.ll
M llvm/test/Transforms/NewGVN/2008-12-09-SelfRemove.ll
M llvm/test/Transforms/NewGVN/2008-12-12-RLE-Crash.ll
M llvm/test/Transforms/NewGVN/2008-12-14-rle-reanalyze.ll
M llvm/test/Transforms/NewGVN/2008-12-15-CacheVisited.ll
M llvm/test/Transforms/NewGVN/2009-01-21-SortInvalidation.ll
M llvm/test/Transforms/NewGVN/2009-01-22-SortInvalidation.ll
M llvm/test/Transforms/NewGVN/2009-03-10-PREOnVoid.ll
M llvm/test/Transforms/NewGVN/2009-07-13-MemDepSortFail.ll
M llvm/test/Transforms/NewGVN/2009-11-12-MemDepMallocBitCast.ll
M llvm/test/Transforms/NewGVN/2010-05-08-OneBit.ll
M llvm/test/Transforms/NewGVN/2011-04-27-phioperands.ll
M llvm/test/Transforms/NewGVN/2011-07-07-MatchIntrinsicExtract.ll
M llvm/test/Transforms/NewGVN/2012-05-22-PreCrash.ll
M llvm/test/Transforms/NewGVN/addrspacecast.ll
M llvm/test/Transforms/NewGVN/assume-equal-xfail.ll
M llvm/test/Transforms/NewGVN/assume-equal.ll
M llvm/test/Transforms/NewGVN/assumes.ll
M llvm/test/Transforms/NewGVN/basic.ll
M llvm/test/Transforms/NewGVN/big-endian.ll
M llvm/test/Transforms/NewGVN/bitcast-of-call.ll
M llvm/test/Transforms/NewGVN/br-identical.ll
M llvm/test/Transforms/NewGVN/commute.ll
M llvm/test/Transforms/NewGVN/compare-condition-changes.ll
M llvm/test/Transforms/NewGVN/crash.ll
M llvm/test/Transforms/NewGVN/dbg-redundant-load.ll
M llvm/test/Transforms/NewGVN/debugloc-xfail.ll
M llvm/test/Transforms/NewGVN/edge.ll
M llvm/test/Transforms/NewGVN/eliminate-ssacopy.ll
M llvm/test/Transforms/NewGVN/flags-simplify.ll
M llvm/test/Transforms/NewGVN/flags.ll
M llvm/test/Transforms/NewGVN/fold-const-expr.ll
M llvm/test/Transforms/NewGVN/fpmath.ll
M llvm/test/Transforms/NewGVN/int_sideeffect.ll
M llvm/test/Transforms/NewGVN/invariant.start.ll
M llvm/test/Transforms/NewGVN/load-from-unreachable-predecessor.ll
M llvm/test/Transforms/NewGVN/metadata-nonnull.ll
M llvm/test/Transforms/NewGVN/metadata-simplify.ll
M llvm/test/Transforms/NewGVN/non-integral-pointers.ll
M llvm/test/Transforms/NewGVN/opt-remarks-xfail.ll
M llvm/test/Transforms/NewGVN/phi-edge-handling.ll
M llvm/test/Transforms/NewGVN/phi-of-ops-move-block.ll
M llvm/test/Transforms/NewGVN/phi-of-ops-simplification-dependencies.ll
M llvm/test/Transforms/NewGVN/phi-of-ops-simplified-to-existing-value-then-changes-again.ll
M llvm/test/Transforms/NewGVN/pr12979.ll
M llvm/test/Transforms/NewGVN/pr14166-xfail.ll
M llvm/test/Transforms/NewGVN/pr17732.ll
M llvm/test/Transforms/NewGVN/pr25440.ll
M llvm/test/Transforms/NewGVN/pr28562.ll
M llvm/test/Transforms/NewGVN/pr31758.ll
M llvm/test/Transforms/NewGVN/pr32403.ll
M llvm/test/Transforms/NewGVN/pr32607.ll
M llvm/test/Transforms/NewGVN/pr32836.ll
M llvm/test/Transforms/NewGVN/pr32838.ll
M llvm/test/Transforms/NewGVN/pr32845.ll
M llvm/test/Transforms/NewGVN/pr32852.ll
M llvm/test/Transforms/NewGVN/pr32897.ll
M llvm/test/Transforms/NewGVN/pr32934.ll
M llvm/test/Transforms/NewGVN/pr32945.ll
M llvm/test/Transforms/NewGVN/pr32952.ll
M llvm/test/Transforms/NewGVN/pr33014.ll
M llvm/test/Transforms/NewGVN/pr33086.ll
M llvm/test/Transforms/NewGVN/pr33116.ll
M llvm/test/Transforms/NewGVN/pr33165-distribute-undef.ll
M llvm/test/Transforms/NewGVN/pr33185.ll
M llvm/test/Transforms/NewGVN/pr33187.ll
M llvm/test/Transforms/NewGVN/pr33204.ll
M llvm/test/Transforms/NewGVN/pr33305.ll
M llvm/test/Transforms/NewGVN/pr33432.ll
M llvm/test/Transforms/NewGVN/pr33461.ll
M llvm/test/Transforms/NewGVN/pr33720.ll
M llvm/test/Transforms/NewGVN/pr34135.ll
M llvm/test/Transforms/NewGVN/pr34430.ll
M llvm/test/Transforms/NewGVN/pr34452.ll
M llvm/test/Transforms/NewGVN/pr35074.ll
M llvm/test/Transforms/NewGVN/pr35125.ll
M llvm/test/Transforms/NewGVN/pr43441.ll
M llvm/test/Transforms/NewGVN/pre-compare.ll
M llvm/test/Transforms/NewGVN/preserve-metadata-for-predicate-replacements.ll
M llvm/test/Transforms/NewGVN/propagate-ir-flags.ll
M llvm/test/Transforms/NewGVN/readattrs.ll
M llvm/test/Transforms/NewGVN/rle-no-phi-translate-xfail.ll
M llvm/test/Transforms/NewGVN/simp-to-self.ll
M llvm/test/Transforms/NewGVN/storeoverstore.ll
M llvm/test/Transforms/NewGVN/todo-pr35074-phi-of-ops.ll
M llvm/test/Transforms/NewGVN/todo-pr36335-phi-undef.ll
M llvm/test/Transforms/NewGVN/todo-pr37121-seens-this-value-a-lot.ll
M llvm/test/Transforms/NewGVN/todo-pr42422-phi-of-ops.ll
M llvm/test/Transforms/NewGVN/verify-memoryphi.ll
Log Message:
-----------
[test][NewGVN] Use -passes=newgvn instead of -newgvn
Use the new PM syntax when specifying the pipeline in regression
tests previously running
"opt -newgvn ..."
Instead we now do
"opt -passes=newgvn ..."
Notice that this also changes the aa-pipeline to become the default
aa-pipeline instead of just basic-aa. Since these tests haven't been
explicitly requesting basic-aa in the past (compared to the test cases
updated in a separate patch involving "-basic-aa -newgvn") it is
assumed that the exact aa-pipeline isn't important for the validity
of the test cases. An alternative could have been to add
-aa-pipeline=basic-aa as well to the run lines, but that might just
add clutter in case the test cases do not care about the aa-pipeline.
This is another step to move away from the legacy PM syntax when
specifying passes in opt.
Differential Revision: https://reviews.llvm.org/D118341
Commit: bcdcf984cc4295de9734ed542069b82930c4ba17
https://github.com/llvm/llvm-project/commit/bcdcf984cc4295de9734ed542069b82930c4ba17
Author: Bjorn Pettersson <bjorn.a.pettersson at ericsson.com>
Date: 2022-01-28 (Fri, 28 Jan 2022)
Changed paths:
M llvm/test/Transforms/NewGVN/2007-07-25-InfiniteLoop.ll
M llvm/test/Transforms/NewGVN/2007-07-26-InterlockingLoops.ll
M llvm/test/Transforms/NewGVN/2007-07-31-NoDomInherit-xfail.ll
M llvm/test/Transforms/NewGVN/2007-07-31-RedundantPhi.ll
M llvm/test/Transforms/NewGVN/2008-07-02-Unreachable.ll
M llvm/test/Transforms/NewGVN/2010-03-31-RedundantPHIs.ll
M llvm/test/Transforms/NewGVN/2010-11-13-Simplify.ll
M llvm/test/Transforms/NewGVN/2011-09-07-TypeIdFor.ll
M llvm/test/Transforms/NewGVN/2016-08-30-MaskedScatterGather-xfail-inseltpoison.ll
M llvm/test/Transforms/NewGVN/2016-08-30-MaskedScatterGather-xfail.ll
M llvm/test/Transforms/NewGVN/MemdepMiscompile.ll
M llvm/test/Transforms/NewGVN/basic-cyclic-opt.ll
M llvm/test/Transforms/NewGVN/basic-undef-test.ll
M llvm/test/Transforms/NewGVN/calloc-load-removal.ll
M llvm/test/Transforms/NewGVN/calls-nonlocal-xfail.ll
M llvm/test/Transforms/NewGVN/calls-readonly.ll
M llvm/test/Transforms/NewGVN/completeness.ll
M llvm/test/Transforms/NewGVN/cond_br.ll
M llvm/test/Transforms/NewGVN/condprop-xfail.ll
M llvm/test/Transforms/NewGVN/condprop.ll
M llvm/test/Transforms/NewGVN/cyclic-phi-handling.ll
M llvm/test/Transforms/NewGVN/deadstore.ll
M llvm/test/Transforms/NewGVN/equivalent-phi.ll
M llvm/test/Transforms/NewGVN/fence-xfail.ll
M llvm/test/Transforms/NewGVN/funclet.ll
M llvm/test/Transforms/NewGVN/lifetime-simple.ll
M llvm/test/Transforms/NewGVN/load-constant-mem.ll
M llvm/test/Transforms/NewGVN/loadforward.ll
M llvm/test/Transforms/NewGVN/malloc-load-removal.ll
M llvm/test/Transforms/NewGVN/memory-handling.ll
M llvm/test/Transforms/NewGVN/non-local-offset.ll
M llvm/test/Transforms/NewGVN/nonescaping-malloc-xfail.ll
M llvm/test/Transforms/NewGVN/null-aliases-nothing.ll
M llvm/test/Transforms/NewGVN/phi-translate-partial-alias.ll
M llvm/test/Transforms/NewGVN/pr10820-xfail.ll
M llvm/test/Transforms/NewGVN/pr24397.ll
M llvm/test/Transforms/NewGVN/pr31472.ll
M llvm/test/Transforms/NewGVN/pr31483.ll
M llvm/test/Transforms/NewGVN/pr31491.ll
M llvm/test/Transforms/NewGVN/pr31501.ll
M llvm/test/Transforms/NewGVN/pr31573.ll
M llvm/test/Transforms/NewGVN/pr31594.ll
M llvm/test/Transforms/NewGVN/pr31613.ll
M llvm/test/Transforms/NewGVN/pr31682.ll
M llvm/test/Transforms/NewGVN/pr33196.ll
M llvm/test/Transforms/NewGVN/pre-new-inst-xfail.ll
M llvm/test/Transforms/NewGVN/predicates.ll
M llvm/test/Transforms/NewGVN/range.ll
M llvm/test/Transforms/NewGVN/refine-stores.ll
M llvm/test/Transforms/NewGVN/rle-must-alias-xfail.ll
M llvm/test/Transforms/NewGVN/rle-nonlocal.ll
Log Message:
-----------
[test][NewGVN] Use '-passes=newgvn' instead of '-basic-aa -newgvn'
This updates NewGVN test cases that were running
"opt -basic-aa -newgvn ..."
to run
"opt -passes=newgvn ..."
instead.
The pipeline will be more similar to what we used to have with
legacy PM by doing it this way. The compatility mode that we've
been using for awhile during transition from legacy PM to new PM,
i.e. using the legacy syntax together with new PM, has resulted in
a pipeline such as
-passes='function(require<basic-aa>),function(newgvn)'
but running the analysis in a separate function pass manager seem
overly complicated for these tests.
Another difference is that we will get the default aa-pipeline instead
of only running basic-aa. That might be a bit questioned (given that
the tests originally specified basic-aa). The output is however
identival for all the test cases modified here regardless of using
basic-aa or the default aa-pipeline.
This is also another small step towards removal of the support for
using the legacy PM syntax in opt.
Differential Revision: https://reviews.llvm.org/D118340
Compare: https://github.com/llvm/llvm-project/compare/10879c26a203...bcdcf984cc42
More information about the All-commits
mailing list