[all-commits] [llvm/llvm-project] c4e689: [clangd][Hover] Suppress initializers with many to...

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Thu Jan 27 04:02:41 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c4e68953f6443b9854ce3ec1dc8756789beafcc1
      https://github.com/llvm/llvm-project/commit/c4e68953f6443b9854ce3ec1dc8756789beafcc1
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2022-01-27 (Thu, 27 Jan 2022)

  Changed paths:
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd][Hover] Suppress initializers with many tokens

This results in excessive memory usage and eats a lot of screen estate.
Especially in the cases with lots of nested macro calls.

This patch tries to remedy it before the release cut by suppressing the
initializers. For better UX we should probably update the expression printer to
truncate those (behind some policy).

Fixes https://github.com/clangd/clangd/issues/917

Differential Revision: https://reviews.llvm.org/D118260




More information about the All-commits mailing list