[all-commits] [llvm/llvm-project] b88a4d: [mlir:GPU] Replace reference to LLVMFuncOp with Fu...

River Riddle via All-commits all-commits at lists.llvm.org
Wed Jan 26 12:05:04 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b88a4d72d91cdd5dbee88aa8491e1a87150189d8
      https://github.com/llvm/llvm-project/commit/b88a4d72d91cdd5dbee88aa8491e1a87150189d8
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-01-26 (Wed, 26 Jan 2022)

  Changed paths:
    M mlir/lib/Dialect/GPU/CMakeLists.txt
    M mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
    M mlir/test/Dialect/GPU/invalid.mlir

  Log Message:
  -----------
  [mlir:GPU] Replace reference to LLVMFuncOp with FuncOpInterface

The GPU dialect currently contains an explicit reference to  LLVMFuncOp
during verification to handle the situation where the kernel has already been
converted. This commit changes that reference to instead use FunctionOpInterface,
which has two main benefits:

* It allows for removing an otherwise unnecessary dependency on the LLVM dialect
* It removes hardcoded assumptions about the lowering path and use of the GPU dialect

Differential Revision: https://reviews.llvm.org/D118172


  Commit: 480cd4cb8560532e544fc0c234749912dde759c6
      https://github.com/llvm/llvm-project/commit/480cd4cb8560532e544fc0c234749912dde759c6
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-01-26 (Wed, 26 Jan 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/Complex/IR/Complex.h
    M mlir/include/mlir/Dialect/Complex/IR/ComplexBase.td
    M mlir/include/mlir/Dialect/Complex/IR/ComplexOps.td
    M mlir/lib/Dialect/Complex/IR/CMakeLists.txt
    M mlir/lib/Dialect/Complex/IR/ComplexDialect.cpp
    M mlir/lib/Dialect/Complex/IR/ComplexOps.cpp
    M mlir/lib/Dialect/StandardOps/IR/Ops.cpp
    M mlir/test/Dialect/Complex/canonicalize.mlir
    A mlir/test/Dialect/Complex/invalid.mlir
    M mlir/test/Dialect/Complex/ops.mlir
    M mlir/test/Dialect/Standard/invalid.mlir
    M mlir/test/Dialect/Standard/ops.mlir

  Log Message:
  -----------
  [mlir] Move the complex support of std.constant to a new complex.constant operation

This is part of splitting up the standard dialect.

Differential Revision: https://reviews.llvm.org/D118182


  Commit: 632a4f8829425325c9d5b110a78bfc6e0bb855e9
      https://github.com/llvm/llvm-project/commit/632a4f8829425325c9d5b110a78bfc6e0bb855e9
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-01-26 (Wed, 26 Jan 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
    M mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
    M mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp
    M mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
    M mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
    M mlir/lib/Dialect/StandardOps/IR/Ops.cpp
    M mlir/lib/Dialect/StandardOps/Transforms/ExpandOps.cpp
    M mlir/test/Conversion/MemRefToLLVM/memref-to-llvm.mlir
    M mlir/test/Conversion/StandardToLLVM/standard-to-llvm.mlir
    M mlir/test/Dialect/MemRef/invalid.mlir
    M mlir/test/Dialect/MemRef/ops.mlir
    M mlir/test/Dialect/Standard/expand-ops.mlir
    M mlir/test/IR/core-ops.mlir
    M mlir/test/IR/invalid-ops.mlir

  Log Message:
  -----------
  [mlir] Move std.generic_atomic_rmw to the memref dialect

This is part of splitting up the standard dialect. The move makes sense anyways,
given that the memref dialect already holds memref.atomic_rmw which is the non-region
sibling operation of std.generic_atomic_rmw (the relationship is even more clear given
they have nearly the same description % how they represent the inner computation).

Differential Revision: https://reviews.llvm.org/D118209


Compare: https://github.com/llvm/llvm-project/compare/6a953d931c4d...632a4f882942


More information about the All-commits mailing list