[all-commits] [llvm/llvm-project] 4691f0: Initialize terminfo.bzl linkopts to None

Jon Meow via All-commits all-commits at lists.llvm.org
Wed Jan 26 11:03:45 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4691f00a63750b14970b71bc9dbb9bd04c8335a8
      https://github.com/llvm/llvm-project/commit/4691f00a63750b14970b71bc9dbb9bd04c8335a8
  Author: jonmeow <46229924+jonmeow at users.noreply.github.com>
  Date:   2022-01-26 (Wed, 26 Jan 2022)

  Changed paths:
    M utils/bazel/terminfo.bzl

  Log Message:
  -----------
  Initialize terminfo.bzl linkopts to None

The underlying issue here is that line 125 checks if linkopts was assigned (by line 120) but it's not initialized, so that becomes a crash. This was noticed by someone trying to use Docker, so no terminfo library installed.

Reviewed By: GMNGeoffrey

Differential Revision: https://reviews.llvm.org/D118270




More information about the All-commits mailing list