[all-commits] [llvm/llvm-project] cbd082: [lldb] Remove ConstString::StaticMemorySize

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cbd0822f2730e2b0d5f1c44b645609fe9554f58e
      https://github.com/llvm/llvm-project/commit/cbd0822f2730e2b0d5f1c44b645609fe9554f58e
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2022-01-26 (Wed, 26 Jan 2022)

  Changed paths:
    M lldb/include/lldb/Core/Declaration.h
    M lldb/include/lldb/Core/FileSpecList.h
    M lldb/include/lldb/Core/Mangled.h
    M lldb/include/lldb/Symbol/Function.h
    M lldb/include/lldb/Utility/ConstString.h
    M lldb/include/lldb/Utility/FileSpec.h
    M lldb/source/Utility/ConstString.cpp

  Log Message:
  -----------
  [lldb] Remove ConstString::StaticMemorySize

Remove ConstString::StaticMemorySize as it is unused and superseded by
GetMemoryStats. It is referenced in a bunch of doc comments but I don't
really understand why. My best guess it that the comments were
copy-pasted from ConstString::MemorySize() even though it didn't make
sense there either. The implementation of StaticMemorySize was being
called on the MemoryPool, not on the ConstString itself.

Differential revision: https://reviews.llvm.org/D118091