[all-commits] [llvm/llvm-project] a5e324: [AMDGPUHSAMetadataStreamer] Do not assume ABI alig...

Nikita Popov via All-commits all-commits at lists.llvm.org
Wed Jan 26 06:45:31 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a5e324e3e2edcc72d9e402b4d846cae615192ad8
      https://github.com/llvm/llvm-project/commit/a5e324e3e2edcc72d9e402b4d846cae615192ad8
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-01-26 (Wed, 26 Jan 2022)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp
    M llvm/test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full-v3.ll
    M llvm/test/CodeGen/AMDGPU/hsa-metadata-from-llvm-ir-full.ll

  Log Message:
  -----------
  [AMDGPUHSAMetadataStreamer] Do not assume ABI alignment for pointers

AMDGPUHSAMetadataStreamer currently assumes that pointer arguments
without align attribute have ABI alignment of the pointee type.
This is incompatible with opaque pointers, but also plain incorrect:
Pointer arguments without explicit alignment have alignment 1. It is
the responsibility of the frontent to add correct align annotations.

Differential Revision: https://reviews.llvm.org/D118229




More information about the All-commits mailing list