[all-commits] [llvm/llvm-project] a2aea7: [libcxx] [test] Fix mismatches between _aligned_ma...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Wed Jan 26 01:53:23 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a2aea7199a5c99260d27ee37f3cda8f752478c02
      https://github.com/llvm/llvm-project/commit/a2aea7199a5c99260d27ee37f3cda8f752478c02
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-01-26 (Wed, 26 Jan 2022)

  Changed paths:
    M libcxx/test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpp

  Log Message:
  -----------
  [libcxx] [test] Fix mismatches between _aligned_malloc and free() on Windows

This allows getting rid of one case of LIBCXX-WINDOWS-FIXME. The fixme
comment was inaccurate; aligned allocation functions are provided these
days, but the test kept failing as it was using mismatched allocation
and free functions.

A similar issue was fixed earlier, in
6596778b46ba69517191e7397289228168064ff4. That test was fixed by
overriding the aligned `operator new` too, and returning a dummy fixed
allocation instead. As this test is libcxx specific, it can use the
internal `std::__libcpp_aligned_free()` instead, to match libcxx's
internal aligned `operator new`.

Differential Revision: https://reviews.llvm.org/D118190




More information about the All-commits mailing list