[all-commits] [llvm/llvm-project] 227d18: [lld][macho][NFC] Make MachO/start-end.s test less...

[Puyan Lotfi via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 227d18b3a87a7bb544b76276a77def10294d1f0a
      https://github.com/llvm/llvm-project/commit/227d18b3a87a7bb544b76276a77def10294d1f0a
  Author: Puyan Lotfi <puyan at puyan.org>
  Date:   2022-01-25 (Tue, 25 Jan 2022)

  Changed paths:
    M lld/test/MachO/start-end.s

  Log Message:
  -----------
  [lld][macho][NFC] Make MachO/start-end.s test less britle by checking for _main:

In start-end.s there is a lit check line `# SEG: _main` to begin the
check at the start of the function main where `_main` is the Darwin name
mangling for C main. Because the text file that FileCheck is getting as
input has the path of the compiler build in it from llvm-mc and
llvm-objdump, and because of the lack of a trailing colon in this check
line we end up inadvertently matching against the line of text with the
compiler path in it in the case where said path contains "_main" some
place. This can be very likely if the compiler branch has "main" or
"_main" in it.

To fix this I include the training : since that will match on the
function label and not the path line.